Use icon-only dismiss button for repeatable delete#26030
Closed
AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
Closed
Use icon-only dismiss button for repeatable delete#26030AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
Conversation
Contributor
|
Missing required label for changelog. Requires at least 1 of: bug, developer, dependencies, internal, localization, major-bug, major-rfe, rfe, regression-fix, removed, skip-changelog. Found: . You can add the required label by adding a comment with the following text: |
Contributor
Author
|
/label rfe |
Member
|
Duplicate of #25964 Please check for existing PRs before creating a new one. |
Member
It doesn't. Also please do not remove the PR template. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the repeatable delete button to use an icon-only design,
removing the visible “Delete/Dismiss” text.
The goal is to align repeatable delete actions with existing Jenkins UI patterns
(e.g. dismiss buttons used in system notifications), while preserving
accessibility.
Changes included:
No functional behavior is changed; clicking the button continues to remove the
repeated block as before.
Note: When hovering over the icon-only button, the button width briefly collapses
due to existing CSS assumptions that previously relied on the presence of text.
This PR focuses only on removing visible text while maintaining accessibility.
Any CSS refinements related to hover width can be addressed separately.
Fixes #18321