Fix New Item validation not disabling submit button#26069
Closed
janfaracik wants to merge 3 commits intojenkinsci:masterfrom
Closed
Fix New Item validation not disabling submit button#26069janfaracik wants to merge 3 commits intojenkinsci:masterfrom
janfaracik wants to merge 3 commits intojenkinsci:masterfrom
Conversation
daniel-beck
requested changes
Jan 6, 2026
Member
Author
Good spot, very odd. I've removed a line from |
janfaracik
added a commit
to janfaracik/jenkins
that referenced
this pull request
Jan 6, 2026
MarkEWaite
pushed a commit
that referenced
this pull request
Feb 9, 2026
* Refine the 'New Item' screen * Simplify SCSS * Fix submission, fix some tests, improve tabbing + focus states * Fix more tests * Simplify JS + hopefully fix test * Update pom.xml * Update Jenkinsfile * Fix issue noticed in #26069 * Restore Jenkinsfile/test pom * Simplify JS * Restore ability to have headings * Fix focus state in Firefox/Chrome * Add separator between items and 'Duplicate an item'
Contributor
|
Please take a moment and address the merge conflicts of your pull request. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Fixes #16416
This PR fixes the OK button not being disabled if there's a duplicate name. The button should be disabled if there is any error on the page.
#16416 (comment) mentions an adjustment to ATH is needed - that's covered in jenkinsci/acceptance-test-harness#2572.
Testing done
Before
Screen.Recording.2026-01-05.at.13.48.34.mov
After
Screen.Recording.2026-01-05.at.13.48.04.mov
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@jenkinsci/sig-ux @daniel-beck
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.