Jenkins 36720 spotbugs cleanup#26082
Closed
Satvik01000 wants to merge 3 commits intojenkinsci:masterfrom
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JENKINS-36720.
Description
This PR contributes to fixing the SpotBugs technical debt in the CLI module. In this PR, the fix is for the potential NPE in BuildCommand.java and DeleteNodeCommand.java
Changes:
hudson.cli.BuildCommand.java:run()method was accessing.ordinalonb.getResult().-1instead of throwing an NPE.hudson.cli.DeleteNodeCommand.java:run()method was calling.doDoDelete()onnode.toComputer().IllegalStateException. This allows the existingcatchblock to handle the error, print it to stderr, and continue the loop to process other nodes.excludesFilter.xml:Testing done
Verified that the changes compile and pass static analysis locally.
mvn spotbugs:check-> BUILD SUCCESS (0 bugs found).mvn test -pl core-> BUILD SUCCESS.No new unit tests were added as these are safety checks for race conditions/edge cases that are difficult to reproduce in a unit test environment without mocking internal core states.
Screenshots (UI changes only)
N/A
Proposed changelog entries
buildanddelete-nodecommands reported by SpotBugs.Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see [documentation](https://www.jenkins.io/doc/developer/security/csp/)).Desired reviewers