Skip to content

Fix anchor links being obscured by header #26100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Gautam-aman wants to merge 2 commits into from
Closed

Fix anchor links being obscured by header #26100

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95805ac
Skip symlink-related tests when symlinks are unsupported
Gautam-aman Jan 10, 2026
c77c8d8
Fix anchor links hidden behind fixed header
Gautam-aman Jan 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/main/resources/lib/layout/skeleton/skeleton.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,3 +95,10 @@ body:has(.jenkins-form-skeleton) {
margin: 0 !important;
}
}
/*
* Fix anchor links being obscured by the fixed Jenkins header
* See: https://github.com/jenkinsci/jenkins/issues/16803
*/
html {
scroll-padding-top: 64px;
}
20 changes: 20 additions & 0 deletions test/src/test/java/hudson/model/DirectoryBrowserSupportTest.java
View file
Open in desktop
Copy link
Contributor

@mawinter69 mawinter69 Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure that you create a new branch based on the master/main and not from another branch that you already used for another change. This here is already part of #26099

Original file line number Diff line number Diff line change
Expand Up @@ -589,6 +589,8 @@ public boolean delete() {
@Test
@Issue("SECURITY-904")
void symlink_outsideWorkspace_areNotAllowed() throws Exception {
Path root = j.jenkins.getRootDir().toPath();
assumeSymlinksSupported(root);
FreeStyleProject p = j.createFreeStyleProject();

File secretsFolder = new File(j.jenkins.getRootDir(), "secrets");
Expand Down Expand Up @@ -721,13 +723,31 @@ void symlink_outsideWorkspace_areNotAllowed() throws Exception {
}
}

// Helper Function
private static void assumeSymlinksSupported(Path dir) throws IOException {
Path target = Files.createTempFile(dir, "symlink-target", ".tmp");
Path link = dir.resolve("symlink-link");

try {
Files.createSymbolicLink(link, target.getFileName());
} catch (UnsupportedOperationException | IOException e) {
assumeTrue(false, "Symbolic links are not supported on this system");
} finally {
Files.deleteIfExists(link);
Files.deleteIfExists(target);
}
}

/*
* If the glob filter is used, we do not want that it leaks some information.
* Presence of a folder means that the folder contains one or multiple results, so we need to hide it completely
*/
@Test
@Issue("SECURITY-904")
void symlink_avoidLeakingInformation_aboutIllegalFolder() throws Exception {
Path root = j.jenkins.getRootDir().toPath();
assumeSymlinksSupported(root);

FreeStyleProject p = j.createFreeStyleProject();

File secretsFolder = new File(j.jenkins.getRootDir(), "secrets");
Expand Down
Loading