Skip to content

Support for unmarshalling records in RobustReflectionConverter#26133

Closed
prathamalwayscomeslast wants to merge 1 commit intojenkinsci:masterfrom
prathamalwayscomeslast:issue-26077
Closed

Support for unmarshalling records in RobustReflectionConverter#26133
prathamalwayscomeslast wants to merge 1 commit intojenkinsci:masterfrom
prathamalwayscomeslast:issue-26077

Conversation

@prathamalwayscomeslast
Copy link
Contributor

Fixes #26077

Currently, deserialization of xml to records is not supported by XStream2. This change allows deserializing to records just like regular classes.

Testing done

  • A minimal test case has been added which works successfully for both records and classes, ensuring no regression.
  • Unit tests covering all possible edge cases will soon be added

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • Serializing record instances to XML and back again is now supported in RobustReflectionConverter

Proposed changelog category

/label rfe

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@jglick

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot bot added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label Jan 16, 2026
@MarkEWaite
Copy link
Contributor

Closing this draft pull request. This is not a good first issue. It was not marked as a good first issue. There are many, many areas that need to be evaluated before this type of change would be considered.

@MarkEWaite MarkEWaite closed this Jan 16, 2026
@prathamalwayscomeslast prathamalwayscomeslast deleted the issue-26077 branch February 5, 2026 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support records in XStream2

2 participants