-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
Fix dropdown help icon layout #26147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fix dropdown help icon layout #26147
Conversation
…isabled When trying to trigger a build of a branch job in a disabled multibranch project, the UI showed 'Build Scheduled' even though the build was not actually scheduled (queue returned null, causing a 302 redirect). Changes: - Updated isBuildable() to check if parent ParameterizedJob is disabled - Changed doBuild() to return 409 CONFLICT when schedule2() returns null - Fixed JavaScript to only treat HTTP 201 as success (not 302 redirects) Fixes issue where disabled multibranch parent allows branch builds to appear scheduled when they are actually rejected.
Reverted the 409 CONFLICT throw back to redirect behavior to maintain API compatibility. The JavaScript change (checking rsp.status === 201) is sufficient to fix the UI notification issue using the existing 201 Created signal.
|
Please use the same before and after screenshots not different examples |
|
I have update the screenshots so that it refers to same example . |
|
@timja any updates regarding this PR ? |
|
Please let me know is this PR need any further change or not ? |
This is not actually what the original issue is reporting. Is it obsolete and the problem has been fixed in the mean time? |
Verified against latest master branch - the issue is still present and hasn't been fixed yet. The PR is still needed. |
Fixes #16838
Description
Fixed a layout issue where the help icon (?) for f:dropdownDescriptorSelector would intersect with the right border of the dropdown when used in constrained containers (like f:repeatableHeteroProperty).
The fix involves:
Reducing the dropdown width slightly (width: calc(100% - 3rem)) in
_select.scss.
Positioning the help icon in the newly created space (right: -2.5rem) in
_layout.scss.
This ensures the icon stays outside the field (avoiding overlap with the internal arrow/text) but remains within the overall footprint of the form item (avoiding intersection with the parent container's border).
Testing done
Manual verification was performed on a local Jenkins instance (2.548-SNAPSHOT):
Screenshots (UI changes only)
Before

After

Proposed changelog entries
Fix help icon layout overlap for dropdownDescriptorSelector
Proposed changelog category
/label bug, web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@timja @mawinter69 @MarkEWaite