Skip to content

Add help remove last build#26152

Closed
AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
AmoghParmar:add-help-remove-last-build
Closed

Add help remove last build#26152
AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
AmoghParmar:add-help-remove-last-build

Conversation

@AmoghParmar
Copy link
Contributor

Fixes JENKINS-75463

This pull request adds missing online help documentation for the
“Remove last build” option of the LogRotator build discarder.

The help text explains the behavior, provides an example,
and references Pipeline usage.

Testing done

  • Built Jenkins locally from source.
  • Verified the new help icon appears for the “Remove last build” option
    in Manage Jenkins → Configure System → Build Discarder → Advanced.
  • Clicked the help icon and confirmed the help text renders correctly.

Screenshots (UI changes only)

Before

Screenshot 2026-01-20 123238
  • No online help was available for the “Remove last build” option.

After

image image
  • A help icon is displayed next to the “Remove last build” option,
    showing detailed documentation when clicked.

Proposed changelog entries

  • Add online help for the “Remove last build” build discarder option.

Proposed changelog category

/label rfe,web-ui

Proposed upgrade guidelines

N/A

@comment-ops-bot comment-ops-bot bot added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Jan 21, 2026
@StefanSpieker
Copy link
Contributor

Thanks for the PR! I do not understand why you changed the dom.js. Can you elaborate on that?

@mawinter69
Copy link
Contributor

Please make sure that when you work on a new issue to start from a clean state based on the jenkinsci master branch.

@mawinter69
Copy link
Contributor

Please link to the github issue #16688 so that the issue is properly closed when merged. Jira is no longer used for core

@AmoghParmar AmoghParmar force-pushed the add-help-remove-last-build branch from 40caf77 to e6f2d36 Compare January 21, 2026 13:03
@AmoghParmar
Copy link
Contributor Author

Thanks for the PR! I do not understand why you changed the dom.js. Can you elaborate on that?

Thanks for the review.

The branch has been rebuilt from a clean jenkinsci/master state and now
contains only a single commit for the help text.
The accidental dom.js change is no longer part of the PR.

@AmoghParmar
Copy link
Contributor Author

@mawinter69 Thanks for the guidance.

I have recreated the branch from a clean jenkinsci/master state and
updated the PR accordingly.

@StefanSpieker
Copy link
Contributor

Thanks for the adjustments, but please fix the build, it is complaining about your file style:

13:11:34 [INFO] --- frontend:2.0.0:corepack (prettier) @ jenkins-parent ---
13:11:34 [INFO] Running 'corepack yarn exec prettier --check .' in /home/jenkins/agent/workspace/Core_jenkins_PR-26152
13:11:35 [INFO] Checking formatting...
13:11:46 [INFO] [warn] core/src/main/resources/hudson/tasks/LogRotator/help-removeLastBuild.html
13:11:58 [INFO] [warn] Code style issues found in the above file. Run Prettier with --write to fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants