Skip to content

fix: insecure-document-method-29 – prevent potential XSS vulnerability #26163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
girichinna27 wants to merge 6 commits into from
Closed

fix: insecure-document-method-29 – prevent potential XSS vulnerability #26163

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
52398ed
fix: documentbuilderfactory-disallow-doctype-decl-missing-110
Jan 22, 2026
0fcc809
Merge pull request #1 from girichinna27/fix/semgrep-documentbuilderfa…
girichinna27 Jan 22, 2026
c4ca132
fix: insecure-document-method-29
Jan 22, 2026
26f6394
Merge pull request #2 from girichinna27/fix/semgrep-insecure-document…
girichinna27 Jan 22, 2026
8466a93
fix: eval-detected-663
Jan 23, 2026
867180a
Merge pull request #3 from girichinna27/fix/semgrep-eval-detected-663…
girichinna27 Jan 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions core/src/main/java/org/jenkins/ui/symbol/Symbol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,7 @@ private static String loadSymbol(String namespace, String name) {
DocumentBuilderFactory dbf = DocumentBuilderFactory.newInstance();
try {
dbf.setFeature(XMLConstants.FEATURE_SECURE_PROCESSING, true);
dbf.setFeature("http://apache.org/xml/features/disallow-doctype-decl", true);
Copy link
Member

@daniel-beck daniel-beck Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? This is redundant per https://semgrep.dev/docs/cheat-sheets/java-xxe#3a-documentbuilderfactory.

DocumentBuilder db = dbf.newDocumentBuilder();
Document doc = db.parse(new StringInputStream(markup));
Element root = doc.getDocumentElement();
Expand Down
2 changes: 1 addition & 1 deletion core/src/main/resources/hudson/PluginManager/_installed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@
).then((rsp) => {
if (!rsp.ok) {
rsp.text().then((responseText) => {
document.getElementById("needRestart").innerHTML = responseText;
document.getElementById("needRestart").textContent = responseText;
Copy link
Member

@daniel-beck daniel-beck Jan 22, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not an adequate solution.

Screenshot 2026-01-22 at 21 38 00

});
}
updateMsg();
Expand Down
Loading