Fix misaligned in-progress status indicator in pipeline view#26226
Fix misaligned in-progress status indicator in pipeline view#26226hharshhsaini wants to merge 2 commits intojenkinsci:masterfrom
Conversation
|
Yay, your first pull request towards Jenkins core was created successfully! Thank you so much! |
|
Hi @MarkEWaite @krisstern @janfaracik @timja, All feedback has been addressed and the PR is ready for another round of review. |
MarkEWaite
left a comment
There was a problem hiding this comment.
@hharshhsaini please refer to the comments from Jan that indicate a problem with the pull request. If you're not interested in fixing the problem, please close the pull request.
@MarkEWaite the layout looks broken in the current "after" state. I’ll revisit the CSS changes and adjust the fix so that the animation is centered without affecting surrounding layout or other icon states. I’ll push an update shortly once the regression is resolved. |
62b547c to
5795ea5
Compare
|
The previous global animation changes have been fully reverted. The fix is now strictly scoped to animated build-status icons inside Layout matches master locally while keeping the animation centered. |
|
@janfaracik fixed the spinning ring , please have a look over this and give feedback for further changes. |
Could you post a before and after of the change? It'd be good to see it misaligned before, and then how your fix has resolved that issue. |
db264b7 to
6576cc0
Compare
The spinning ring SVG uses viewBox="-256 -256 512 512" (centered at 0,0). With transform-origin: 0 0 and transform-box: view-box, the animation origin resolves to the top-left corner (-256,-256) of the viewBox instead of its center, causing the ring to wobble irregularly. Changing transform-origin to center fixes the issue by rotating around the geometric center of the viewBox. Fixes JENKINS-71978
6576cc0 to
0f9825e
Compare
these are the before screenshots of the spinning ring @janfaracik |







Fixes #18750
This pull request fixes a UI layout issue where the in progress (animated) pipeline status indicator appeared misaligned in the status column.
The animation was anchored to the top-left of the icon instead of its geometric center, causing the indicator to look irregular while running.
The fix corrects the animation origin so the status icon remains visually centered and stable during execution.
Testing done
Before the fix (irregular alignment):
transform-origin: 0 0, causing spin/pulse animations to anchor to the top-left of the icon.After the fix (centered alignment):
transform origin: centerandtransform-box: view-box.Manual verification:
mvn -pl war jetty:runyarn lintandmvn spotless:applyScreenshots (UI changes only)
Before
https://drive.google.com/file/d/1LlfE6JuqZfhKSHzN-F7gzxIjG0IuWCl6/view?usp=sharing
After
https://drive.google.com/file/d/1JM8MvTzKAVR1Ho6iKQSW2bz6_iOeS_0N/view?usp=sharing
Proposed changelog entries
Proposed changelog category
/label bug, web-ui
Proposed upgrade guidelines
N/A
Submitter checklist
Desired reviewers
@jenkinsci/core-pr-reviewers
Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title.lts-candidateto be considered.