Skip to content

Fix misaligned in-progress status indicator in pipeline view#26226

Closed
hharshhsaini wants to merge 2 commits intojenkinsci:masterfrom
hharshhsaini:ux/pipeline-status-alignment
Closed

Fix misaligned in-progress status indicator in pipeline view#26226
hharshhsaini wants to merge 2 commits intojenkinsci:masterfrom
hharshhsaini:ux/pipeline-status-alignment

Conversation

@hharshhsaini
Copy link

@hharshhsaini hharshhsaini commented Jan 30, 2026

Fixes #18750

This pull request fixes a UI layout issue where the in progress (animated) pipeline status indicator appeared misaligned in the status column.
The animation was anchored to the top-left of the icon instead of its geometric center, causing the indicator to look irregular while running.

The fix corrects the animation origin so the status icon remains visually centered and stable during execution.


Testing done

Before the fix (irregular alignment):

  • The animation used transform-origin: 0 0, causing spin/pulse animations to anchor to the top-left of the icon.
  • The in-progress indicator appeared offset or “wobbly” while running.
  • The issue was most visible when icon size was set to Large.

After the fix (centered alignment):

  • Updated SCSS applies transform origin: center and transform-box: view-box.
  • The animation is now anchored to the geometric center of the SVG.
  • The in-progress indicator remains stable and centered within the status column.
  • Verified consistency across Dashboard, Build History, and Project pages.

Manual verification:

  • Ran Jenkins locally using mvn -pl war jetty:run
  • Triggered multiple Pipeline builds to reproduce the issue
  • Verified behavior for running, successful, and failed builds
  • Tested on Chrome and Firefox
  • Ran yarn lint and mvn spotless:apply

Screenshots (UI changes only)

Before

https://drive.google.com/file/d/1LlfE6JuqZfhKSHzN-F7gzxIjG0IuWCl6/view?usp=sharing

After

https://drive.google.com/file/d/1JM8MvTzKAVR1Ho6iKQSW2bz6_iOeS_0N/view?usp=sharing


Proposed changelog entries

  • Fix misaligned in progress pipeline status indicator animation

Proposed changelog category

/label bug, web-ui


Proposed upgrade guidelines

N/A


Submitter checklist

  • The issue is well described and linked.
  • The changelog entry is appropriate for users and written in the imperative mood.
  • Manual testing performed and described (UI only change).
  • No new public APIs were added.
  • No deprecations were introduced.
  • UI changes do not introduce CSP regressions.
  • No new dependencies were introduced.

Desired reviewers

@jenkinsci/core-pr-reviewers


Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title.
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@welcome
Copy link

welcome bot commented Jan 30, 2026

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added bug For changelog: Minor bug. Will be listed after features web-ui The PR includes WebUI changes which may need special expertise labels Jan 30, 2026
@hharshhsaini
Copy link
Author

hharshhsaini commented Jan 31, 2026

Hi @MarkEWaite @krisstern @janfaracik @timja,

All feedback has been addressed and the PR is ready for another round of review.
Thank you for your time I’m happy to make further adjustments if needed.

@janfaracik
Copy link
Member

janfaracik commented Feb 7, 2026

Hey. Your screenshots don't show a clear before/after, the UI is also broken in the after - as well as when running locally.

Screenshot 2026-02-07 at 21 28 01

The spinning ring is completely misaligned:

image

Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hharshhsaini please refer to the comments from Jan that indicate a problem with the pull request. If you're not interested in fixing the problem, please close the pull request.

@hharshhsaini
Copy link
Author

@hharshhsaini please refer to the comments from Jan that indicate a problem with the pull request. If you're not interested in fixing the problem, please close the pull request.

@MarkEWaite the layout looks broken in the current "after" state. I’ll revisit the CSS changes and adjust the fix so that the animation is centered without affecting surrounding layout or other icon states.

I’ll push an update shortly once the regression is resolved.

@hharshhsaini hharshhsaini force-pushed the ux/pipeline-status-alignment branch from 62b547c to 5795ea5 Compare February 12, 2026 16:43
@hharshhsaini
Copy link
Author

The previous global animation changes have been fully reverted. The fix is now strictly scoped to animated build-status icons inside _icons.scss (2-line change only). _style.scss matches upstream.

Layout matches master locally while keeping the animation centered.

Please let me know if anything else needs adjustment.
Screenshot 2026-02-12 at 10 05 16 PM
Screenshot 2026-02-12 at 10 09 13 PM
Screenshot 2026-02-12 at 10 10 59 PM

@hharshhsaini
Copy link
Author

@janfaracik fixed the spinning ring , please have a look over this and give feedback for further changes.

@janfaracik
Copy link
Member

janfaracik commented Feb 17, 2026

@janfaracik fixed the spinning ring , please have a look over this and give feedback for further changes.

Could you post a before and after of the change? It'd be good to see it misaligned before, and then how your fix has resolved that issue.

@hharshhsaini hharshhsaini force-pushed the ux/pipeline-status-alignment branch 2 times, most recently from db264b7 to 6576cc0 Compare February 18, 2026 03:33
The spinning ring SVG uses viewBox="-256 -256 512 512" (centered at 0,0).
With transform-origin: 0 0 and transform-box: view-box, the animation
origin resolves to the top-left corner (-256,-256) of the viewBox instead
of its center, causing the ring to wobble irregularly.

Changing transform-origin to center fixes the issue by rotating around
the geometric center of the viewBox.

Fixes JENKINS-71978
@hharshhsaini hharshhsaini force-pushed the ux/pipeline-status-alignment branch from 6576cc0 to 0f9825e Compare February 18, 2026 03:36
@hharshhsaini
Copy link
Author

Screenshot 2026-02-18 at 8 49 32 AM Screenshot 2026-02-18 at 8 50 40 AM

these are the before screenshots of the spinning ring @janfaracik

@janfaracik
Copy link
Member

I can't reproduce the initial issue (nor does the icon in the issue look standard). I've ran your PR and it's still broken:

image

Closing this.

@janfaracik janfaracik closed this Feb 19, 2026
@hharshhsaini hharshhsaini deleted the ux/pipeline-status-alignment branch February 19, 2026 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug For changelog: Minor bug. Will be listed after features web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JENKINS-71978] Pipeline status gif is irregular

3 participants