Skip to content

Restore unsaved changes warning in new Manage Jenkins UI #26292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Maanvi212006 wants to merge 3 commits into from
Closed

Restore unsaved changes warning in new Manage Jenkins UI #26292

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b2e9762
[JENKINS-26270] Restore unsaved changes warning in new Manage Jenkins UI
Maanvi212006 Feb 9, 2026
230b2a5
Merge branch 'master' into fix/unsaved-changes-warning
Maanvi212006 Feb 9, 2026
95d7fa0
Merge branch 'master' into fix/unsaved-changes-warning
Maanvi212006 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions core/src/main/resources/lib/layout/settings-subpage.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ THE SOFTWARE.
permissions="${attrs.permissions}"
type="${newManageJenkins ? 'two-column' : 'one-column'}">

<st:adjunct includes="hudson-behavior"/>
Copy link
Contributor

@mawinter69 mawinter69 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The hudson-behavior.js is always included and even when not that would not be the correct way.


<j:if test="${attrs.includeBreadcrumb}">
<!-- Hacky - this will be improved in subsequent PRs -->
<j:choose>
Expand Down Expand Up @@ -131,13 +133,19 @@ THE SOFTWARE.
</j:choose>
</l:defer.placeholder>
<l:defer.children>
<d:invokeBody />
<div class="jenkins-config">
Copy link
Contributor

@mawinter69 mawinter69 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see why this should solve the problem. To detect that there is a changed field there is lib.form.confirm.js. I think it is loaded but for some reason it doesn't catch the changes.

<d:invokeBody />
</div>
</l:defer.children>

</l:defer>
</j:when>
<j:otherwise>
<d:invokeBody />
<div class="jenkins-config">
<d:invokeBody />
</div>
</j:otherwise>

</j:choose>
</div>
</div>
Expand Down
Loading