Fast incremental of commons file upload 2.0.0-M5#26330
Closed
MarkEWaite wants to merge 4 commits intojenkinsci:masterfrom
Closed
Fast incremental of commons file upload 2.0.0-M5#26330MarkEWaite wants to merge 4 commits intojenkinsci:masterfrom
MarkEWaite wants to merge 4 commits intojenkinsci:masterfrom
Conversation
Method names changed in Apache Commons File Upload commits: * apache/commons-fileupload@6555c234 * apache/commons-fileupload@07ef5fbb * apache/commons-fileupload@1e517228 * apache/commons-fileupload@74ca343e Should not be merged until Stapler has released pull request: * jenkinsci/stapler#754 Needs interactive testing, plugin BOM testing, and acceptance test harness testing before it is merged.
Contributor
Author
|
Build is available. Closing the pull request |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commons file upload Fast incremental for use in ATH and BOM testing
Apache Commons File Upload 2.0.0-M5 has released with breaking changes to the API. The breaking changes have been adapted in Stapler and in Jenkins core. The changes need to be tested in BOM and in ATH. This pull request will generate an incremental build for testing.
Used for testing pull requests:
Testing done
Tested interactively with a local build. Tested file uploading in both core (via the upload plugin feature) and two plugins (Scriptler and Sidebar Link)
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label skip-changelog
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
N/A
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.