Add index variable to forEach loop in queue-items.jelly#26355
Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom Feb 24, 2026
Merged
Add index variable to forEach loop in queue-items.jelly#26355MarkEWaite merged 1 commit intojenkinsci:masterfrom
MarkEWaite merged 1 commit intojenkinsci:masterfrom
Conversation
Fixes a regression in the Build History widget when all the queued tasks show up with the same number
duemir
commented
Feb 23, 2026
| <j:if test="${!queuedItems.isEmpty()}"> | ||
| <span class="app-builds-container__heading">${%Pending}</span> | ||
| <j:forEach var="pageEntry" items="${queuedItems}"> | ||
| <j:forEach var="pageEntry" items="${queuedItems}" indexVar="i"> |
Member
Author
There was a problem hiding this comment.
JEXL on line 46 uses variable i.
gbhat618
reviewed
Feb 23, 2026
| <div class="app-builds-container__item__inner"> | ||
| <div class="app-builds-container__item__inner__link"> | ||
| <!-- Don't use math unless needed, in case nextBuildNumber is not numeric --> | ||
| #${queuedItems.size() == 1 ? it.widget.owner.nextBuildNumber : it.widget.owner.nextBuildNumber+queuedItems.size()-i-1} |
gbhat618
approved these changes
Feb 23, 2026
MarkEWaite
approved these changes
Feb 23, 2026
Contributor
MarkEWaite
left a comment
There was a problem hiding this comment.
This PR is now ready for merge. We will merge it after approximately 24 hours if there is no negative feedback.
/label ready-for-merge
Contributor
|
Merging now so that it will be included in weekly 2.552. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a regression in the Build History widget when all the queued tasks show up with the same number. Which I think fixes #16748
Testing done
Expected: Build history shows a unique incremental number for each queued pipeline task
Actual: All queued tasks show the same number
Screenshots (UI changes only)
Before
After
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@mention
Before the changes are marked as
ready-for-merge:Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.