Add missing 'Keep this build forever' button to new build page#26364
Closed
subwaycookiecrunch wants to merge 2 commits intojenkinsci:masterfrom
Closed
Add missing 'Keep this build forever' button to new build page#26364subwaycookiecrunch wants to merge 2 commits intojenkinsci:masterfrom
subwaycookiecrunch wants to merge 2 commits intojenkinsci:masterfrom
Conversation
janfaracik
reviewed
Feb 25, 2026
Member
janfaracik
left a comment
There was a problem hiding this comment.
Thanks for contributing. Going to close this as a duplicate as this work has been done in #11204
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26196
The new build page (
new-build-page.flag) was missing the "Keep this build forever" toggle because OverviewTab/index.jelly never included logKeep.jelly. The old build page had it in the controls section of index.jelly. Added the include to the details-bar.Testing done
Ran a local Jenkins instance with
new-build-page.flagenabled, created a freestyle job, ran a build, and confirmed the "Keep this build forever" button now shows up in the overview tab's details bar. Toggling it correctly switches to "Don't keep this build forever". Also confirmed the old build page still works fine with the flag disabled.This is a single Jelly include — logKeep.jelly handles all the permission checks internally, so there's no new logic to unit test.
Screenshots (UI changes only)
Before
"Keep this build forever" button is absent from the new build page.
After
"Keep this build forever" button appears in the details bar next to the edit description button.
Proposed changelog entries
Proposed changelog category
/label bug
Proposed upgrade guidelines
N/A
Submitter checklist
@Restrictedor have@since TODOJavadocs, as appropriate.@Deprecated(since = "TODO")or@Deprecated(forRemoval = true, since = "TODO"), if applicable.evalto ease future introduction of Content Security Policy (CSP) directives (see documentation).Desired reviewers
@janfaracik
Maintainer checklist
upgrade-guide-neededlabel is set and there is a Proposed upgrade guidelines section in the pull request title (see example).lts-candidateto be considered.