Skip to content

Fix newView link to use context-relative URL instead of rootURL #26383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
sahilleth wants to merge 2 commits into from
Closed

Fix newView link to use context-relative URL instead of rootURL #26383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01b3d9e
Fix newView link to use context-relative URL instead of rootURL
sahilleth Feb 28, 2026
ee4ded6
Use request.contextPath for view tab hrefs to fix Windows test
sahilleth Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions core/src/main/resources/hudson/views/DefaultMyViewsTabBar/myViewTabs.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,10 @@ THE SOFTWARE.
<!-- view tab bar -->
<l:tabBar>
<j:forEach var="v" items="${it.sort(views)}">
<l:tab name="${v.displayName}" active="${v==currentView}" href="${rootURL}/${v.url}" />
<l:tab name="${v.displayName}" active="${v==currentView}" href="${request.contextPath}/${v.url}" />
</j:forEach>
<j:if test="${currentView.hasPermission(currentView.CREATE)}">
<l:tabNewItem href="${rootURL}/${currentView.owner.url}newView" title="${%New View}" />
<l:tabNewItem href="${request.contextPath}/${currentView.owner.url}newView" title="${%New View}" />
</j:if>
</l:tabBar>
</j:jelly>
8 changes: 4 additions & 4 deletions core/src/main/resources/hudson/views/DefaultViewsTabBar/viewTabs.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ THE SOFTWARE.
<j:when test="${newDashboardPage}">
<div class="app-build-tabs">
<j:forEach var="tab" items="${it.sort(views)}">
<a href="${rootURL}/${tab.url}"
<a href="${request.contextPath}/${tab.url}"
class="jenkins-button ${tab == currentView ? '' : 'jenkins-button--tertiary'}">
<j:if test="${tab.iconFileName != null}">
<l:icon src="${tab.iconFileName}" />
Expand All @@ -41,7 +41,7 @@ THE SOFTWARE.
</j:forEach>

<j:if test="${currentView.hasPermission(currentView.CREATE)}">
<a href="${rootURL}/${currentView.owner.url}newView" tooltip="${%New View}" class="jenkins-button jenkins-button--tertiary">
<a href="${request.contextPath}/${currentView.owner.url}newView" tooltip="${%New View}" class="jenkins-button jenkins-button--tertiary">
<l:icon src="symbol-add" />
</a>
</j:if>
Expand All @@ -50,10 +50,10 @@ THE SOFTWARE.
<j:otherwise>
<l:tabBar>
<j:forEach var="v" items="${it.sort(views)}">
<l:tab name="${v.displayName}" active="${v==currentView}" href="${rootURL}/${v.url}" />
<l:tab name="${v.displayName}" active="${v==currentView}" href="${request.contextPath}/${v.url}" />
</j:forEach>
<j:if test="${currentView.hasPermission(currentView.CREATE)}">
<l:tabNewItem href="${rootURL}/${currentView.owner.url}newView" title="${%New View}" />
<l:tabNewItem href="${request.contextPath}/${currentView.owner.url}newView" title="${%New View}" />
</j:if>
</l:tabBar>
</j:otherwise>
Expand Down
Loading