Fix breadcrumb dropdown not opening on smaller viewports#26391
Open
AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
Open
Fix breadcrumb dropdown not opening on smaller viewports#26391AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
AmoghParmar wants to merge 1 commit intojenkinsci:masterfrom
Conversation
comment-ops-bot
bot
added
bug
MarkEWaite
changed the title
| animation: "tooltip", | ||
| touch: false, | ||
| touch: true, | ||
| interactive: true, |
Contributor
There was a problem hiding this comment.
Has this been tested on an actual touch device, or only via DevTools responsive mode? Also worth checking if interactive: true introduces any unintended side effects on the hover-based dropdowns given they share the same Tippy config base.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #26390
Problem
The breadcrumb dropdown indicator becomes unresponsive on smaller viewports and in DevTools responsive mode. Clicking the dropdown indicator produces no response and no console errors.
Cause
The
.dropdown-indicatordropdown was configured withtouch: falsein the Tippy.js-based Jenkins dropdown implementation.When the browser reports touch capability (DevTools responsive mode or real touch devices), Tippy ignores interaction events entirely, preventing the dropdown from opening.
Fix
Updated the Tippy configuration in:
src/main/js/components/dropdowns/jumplists.jstouch: false→touch: truefor.dropdown-indicatorinteractive: trueto prevent the dropdown from closing before item clicks registerThe hover-based
.hoverable-model-linkdropdown intentionally keepstouch: false, since hover interactions are not applicable on touch devices.Testing Done
Tested manually on Jenkins 2.552-SNAPSHOT (Ubuntu 24.04 / Java 21):
Screenshots (UI changes only)
Before
After
(dropdown opens correctly on click at all viewport sizes)
Automated Tests
This change affects browser interaction behaviour handled by Tippy.js and depends on touch capability detection, which is difficult to reliably simulate in existing Jenkins UI test infrastructure. Manual verification was performed instead.
Proposed Changelog Entry
Fix breadcrumb dropdown not responding to clicks on smaller viewports and touch-capable devices.
Proposed Changelog Category
/label bug, web-ui
Proposed Upgrade Guidelines
N/A
Submitter Checklist
Desired Reviewers
@jenkinsci/core-pr-reviewers