Skip to content

Add missing jackson3-api and snakeyaml-engine-api detached plugin#26394

Merged
MarkEWaite merged 1 commit intojenkinsci:masterfrom
jonesbusy:feature/add-missing-detached-plugin
Mar 5, 2026
Merged

Add missing jackson3-api and snakeyaml-engine-api detached plugin#26394
MarkEWaite merged 1 commit intojenkinsci:masterfrom
jonesbusy:feature/add-missing-detached-plugin

Conversation

@jonesbusy
Copy link
Contributor

Supersedes: #26393

Junit now depends on jackson3-api instead of jackson2-api. Need to also include dependency of jackson3-api (snakeyaml-engine-api)

Testing done

I just run the 2 failing tests

mvn spotless:apply
mvn -Dtest="ClassicPluginStrategyTest#testDisabledDependencyClassLoader" test
mvn -Dtest="LoadDetachedPluginsTest#upgradeFromJenkins1" test

Screenshots (UI changes only)

Before

After

Proposed changelog entries

  • human-readable text

Proposed changelog category

/label skip-changelog

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
  • New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
  • For dependency updates, there are links to external changelogs and, if possible, full differentials.
  • For new APIs and extension points, there is a link to at least one consumer.

Desired reviewers

@MarkEWaite @timja

Before the changes are marked as ready-for-merge:

Maintainer checklist

  • There are at least two (2) approvals for the pull request and no outstanding requests for change.
  • Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
  • Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
  • Proper changelog labels are set so that the changelog can be generated automatically.
  • If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
  • If it would make sense to backport the change to LTS, be a Bug or Improvement, and either the issue or pull request must be labeled as lts-candidate to be considered.

@comment-ops-bot comment-ops-bot bot added the skip-changelog Should not be shown in the changelog label Mar 2, 2026
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess, maybe we could drop the dependencies at some point?

Copy link

@A1exKH A1exKH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@timja
Copy link
Member

timja commented Mar 3, 2026

/label ready-for-merge


This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label Mar 3, 2026
@MarkEWaite MarkEWaite merged commit ac060ea into jenkinsci:master Mar 5, 2026
18 checks passed
@jonesbusy jonesbusy deleted the feature/add-missing-detached-plugin branch March 5, 2026 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback skip-changelog Should not be shown in the changelog

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants