Skip to content

Render floatingBox.jelly for computer actions on Computer page#26423

Closed
Divya07-22 wants to merge 1 commit intojenkinsci:masterfrom
Divya07-22:floatingbox-computer-fix
Closed

Render floatingBox.jelly for computer actions on Computer page#26423
Divya07-22 wants to merge 1 commit intojenkinsci:masterfrom
Divya07-22:floatingbox-computer-fix

Conversation

@Divya07-22
Copy link

Fixes #23461

Testing done

Manually tested using a plugin that provides a computer action with floatingBox.jelly. Verified that after this change, the floating box correctly appears on the Computer (agent/node) page, whereas previously it did not render.

Screenshots (UI changes only)

Before

No floating box displayed for computer actions on the Computer page.

After

Floating box is now visible for computer actions on the Computer page.

Proposed changelog entries

  • Render floatingBox.jelly for computer actions on the Computer page to improve UI consistency and allow plugin actions to display floating boxes for nodes/agents.

Proposed changelog category

/label rfe, web-ui

Proposed upgrade guidelines

N/A

Submitter checklist

  • The issue, if it exists, is well-described.
  • The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
  • There is automated testing or an explanation as to why this change has no tests.
  • UI changes do not introduce regressions when enforcing the current default rules of Content Security Policy Plugin. In particular, new or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).

Desired reviewers

@jenkinsci/core-pr-reviewers

@welcome
Copy link

welcome bot commented Mar 7, 2026

Yay, your first pull request towards Jenkins core was created successfully! Thank you so much!

A contributor will provide feedback soon. Meanwhile, you can join the chats and community forums to connect with other Jenkins users, developers, and maintainers.

@comment-ops-bot comment-ops-bot bot added rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise labels Mar 7, 2026
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Mar 7, 2026

Closing this pull request because the user experience SIG is moving in another direction, per:

Closing also because the submitter did not provide screenshots to show the changed behavior.

Closing also because the submitter did not state which plugin was used for the interactive testing, especially since there is no known plugin that provides a floatingbox.jelly. I suspect that the statement from the pull request submission is false when it says that the submitter:

Manually tested using a plugin that provides a computer action with floatingBox.jelly.

@MarkEWaite MarkEWaite closed this Mar 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted web-ui The PR includes WebUI changes which may need special expertise

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[JENKINS-24783] Computer index.jelly has no provision for rendering floatingBox.jelly included by Actions on the Computer

2 participants