Skip to content

[JENKINS-71047] Deprecate inline JS event handlers #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 5 commits into from
Aug 15, 2025
Merged

[JENKINS-71047] Deprecate inline JS event handlers #8061

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78fdc39
[JENKINS-71046][JENKINS-71047] Deprecate inline JS event handlers
yaroslavafenkin May 29, 2023
86a3e2b
Merge branch 'master' into deprecate-inline-handlers
daniel-beck Aug 13, 2025
e496ea9
Update readOnlyTextbox.jelly
timja Aug 13, 2025
8b7faaa
Apply suggestion from @daniel-beck
timja Aug 13, 2025
83a5ec1
Apply suggestion from @daniel-beck
timja Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion core/src/main/resources/lib/form/radio.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ THE SOFTWARE.
<st:attribute name="checked" />
<st:attribute name="value" />
<st:attribute name="id" />
<st:attribute name="onclick" />
<st:attribute name="onclick" deprecated="true">onclick handler. Deprecated; assign an ID and look up the element that way to attach event handlers.</st:attribute>
Copy link
Member

@timja timja May 29, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may be better to use class name as repeatable elements don't work properly with IDs from what I remember.

IDs are safe to use in standalone pages / configuration forms that won't be used in repeatable elements

<st:attribute name="title">
If specified, this human readable text will follow the radio, and clicking this text also
toggles the radio.
Expand Down
6 changes: 6 additions & 0 deletions core/src/main/resources/lib/form/readOnlyTextbox.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,12 @@ THE SOFTWARE.
If @field is specified, this will be inferred automatically,
which is the recommended approach.
</st:attribute>
<st:attribute name="onchange" deprecated="true">
onchange handler. Deprecated; assign an ID and look up the element that way to attach event handlers.
</st:attribute>
<st:attribute name="onkeyup" deprecated="true">
onkeyup handler. Deprecated; assign an ID and look up the element that way to attach event handlers.
</st:attribute>
</st:documentation>
<f:prepareDatabinding />
<input class="jenkins-input ${attrs.checkUrl!=null?'validated':''} ${attrs.clazz}"
Expand Down