Skip to content

[JENKINS-71047] Deprecate inline JS event handlers #8061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timja merged 5 commits into from
Aug 15, 2025
Merged

[JENKINS-71047] Deprecate inline JS event handlers #8061

Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
78fdc39
[JENKINS-71046][JENKINS-71047] Deprecate inline JS event handlers
yaroslavafenkin May 29, 2023
86a3e2b
Merge branch 'master' into deprecate-inline-handlers
daniel-beck Aug 13, 2025
e496ea9
Update readOnlyTextbox.jelly
timja Aug 13, 2025
8b7faaa
Apply suggestion from @daniel-beck
timja Aug 13, 2025
83a5ec1
Apply suggestion from @daniel-beck
timja Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions core/src/main/resources/lib/form/readOnlyTextbox.jelly
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,20 @@ THE SOFTWARE.
If @field is specified, this will be inferred automatically,
which is the recommended approach.
</st:attribute>
<st:attribute name="onchange" deprecated="true">
Inline JavaScript to execute when the textbox is changed.
Deprecated because this attribute is incompatible with adding Content-Security-Policy to the Jenkins UI in the future.
Set 'id' or 'class' attributes as appropriate to look up this element in external Javascript files (e.g. adjuncts)
to add the desired behavior there (DOMContentLoaded event in static forms, Behaviour.specify if this element may be
dynamically added). See https://github.com/jenkinsci/jenkins/pull/6852 for an example.
</st:attribute>
<st:attribute name="onkeyup" deprecated="true">
Inline JavaScript to execute when the keyup event is fired.
Deprecated because this attribute is incompatible with adding Content-Security-Policy to the Jenkins UI in the future.
Set 'id' or 'class' attributes as appropriate to look up this element in external Javascript files (e.g. adjuncts)
to add the desired behavior there (DOMContentLoaded event in static forms, Behaviour.specify if this element may be
dynamically added). See https://github.com/jenkinsci/jenkins/pull/6852 for an example.
</st:attribute>
</st:documentation>
<f:prepareDatabinding />
<input class="jenkins-input ${attrs.checkUrl!=null?'validated':''} ${attrs.clazz}"
Expand Down