fix: restore argLine in vanilla-package surefire config - #740
Merged
oleg-nenashev merged 1 commit intoJun 30, 2026
Merged
Conversation
romanisb
commented
Jun 30, 2026
| <excludes> | ||
| <exclude>**/its/**.java</exclude> | ||
| </excludes> | ||
| <argLine>-Djdk.net.URLClassPath.disableClassPathURLCheck=true --add-opens=java.base/java.util=ALL-UNNAMED --add-opens=java.base/java.lang=ALL-UNNAMED --add-opens=java.base/java.lang.invoke=ALL-UNNAMED ${argLine}</argLine> |
Contributor
Author
There was a problem hiding this comment.
The override, defined in lin 228, removes the surefire settings from https://github.com/jenkinsci/jenkinsfile-runner/blob/main/pom.xml#L201. Not sure which direction is prefered here. Just reused the configuration again here. Could be considered to clean up all the configuration in the future at one point.
Contributor
Author
|
@oleg-nenashev if everything is fine, would it be possible to trigger a new release? |
oleg-nenashev
approved these changes
Jun 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@oleg-nenashev this should fix the two CI tests failing in https://github.com/jenkinsci/jenkinsfile-runner/runs/84234113409.
Testing done
Submitter checklist