Skip to content

Migrate tests to JUnit5#14

Merged
markrekveld merged 1 commit intojenkinsci:mainfrom
strangelookingnerd:migrate_to_junit5
Feb 16, 2025
Merged

Migrate tests to JUnit5#14
markrekveld merged 1 commit intojenkinsci:mainfrom
strangelookingnerd:migrate_to_junit5

Conversation

@strangelookingnerd
Copy link
Contributor

@strangelookingnerd strangelookingnerd commented Feb 14, 2025

This PR aims to migrate all tests to JUnit5. Changes include:

  • Migrate annotations
  • Migrate assertions
  • Minor cleanup
  • Remove public visibility of test classes and methods
  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@strangelookingnerd strangelookingnerd requested a review from a team as a code owner February 14, 2025 14:30
@strangelookingnerd
Migrate tests to JUnit5
20c4092 
* Migrate annotations and imports
* Migrate assertions
* Remove public visibility for test classes and methods
* Minor clean up
@markrekveld markrekveld merged commit e5ed923 into jenkinsci:main Feb 16, 2025
17 checks passed
@markrekveld
Copy link
Contributor

markrekveld commented Feb 16, 2025

Thanks for your contribution @strangelookingnerd

@strangelookingnerd strangelookingnerd deleted the migrate_to_junit5 branch February 16, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markrekveld markrekveld markrekveld approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@strangelookingnerd @markrekveld