Skip to content

fix: use upstream Maven VersionComparator logic#706

Merged
rantoniuk merged 2 commits intojenkinsci:masterfrom
Hardikrathod01:bugfix/issue_666_versioncomparator_sort_logic
Jun 5, 2025
Merged

fix: use upstream Maven VersionComparator logic#706
rantoniuk merged 2 commits intojenkinsci:masterfrom
Hardikrathod01:bugfix/issue_666_versioncomparator_sort_logic

Conversation

@Hardikrathod01
Copy link
Contributor

@Hardikrathod01 Hardikrathod01 commented Jun 2, 2025

Use only upstream comparator from maven ComparableVersion.
Fixes #666

  • Make sure you are requesting to pull a topic/feature/bugfix branch (right side) and not your master branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@Hardikrathod01 Hardikrathod01 requested a review from a team as a code owner June 2, 2025 17:14
@rantoniuk
Copy link
Member

Manual tests OK, the result is great.

Before After
Before After

@rantoniuk rantoniuk merged commit eb4fc26 into jenkinsci:master Jun 5, 2025
17 checks passed
@rantoniuk rantoniuk added the bug label Jun 5, 2025
@rantoniuk rantoniuk changed the title Bugfix/issue 666 versioncomparator sort logic fix: use upstream Maven VersionComparator logic Jun 5, 2025
@Hardikrathod01 Hardikrathod01 deleted the bugfix/issue_666_versioncomparator_sort_logic branch June 17, 2025 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VersionComparator doesn't sort logically if version contains dashes

2 participants