-
-
Notifications
You must be signed in to change notification settings - Fork 293
Provide pipeline names for steps and selectors #757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
4d74121 to
821e406
Compare
821e406 to
76e2b91
Compare
rantoniuk
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for resurrecting this old feature request!
-
I added some re-wording change suggestions for consistency
-
Could you also extend / update [the documentation](https://jenkinsci.github.io/jira-plugin/#/usage-examples that lives in the docs/?
src/main/java/hudson/plugins/jira/selector/perforce/P4JobIssueSelector.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/jira/selector/DefaultIssueSelector.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/jira/selector/ExplicitIssueSelector.java
Outdated
Show resolved
Hide resolved
src/main/java/hudson/plugins/jira/selector/JqlIssueSelector.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Radek Antoniuk <[email protected]>
|
I applied your suggestions butI'm not sure about the consistency. I'd prefer to have |
|
I looked at other plugins and I agree with you, so:
and this should be good to go. |
7c48e69 to
1067a87
Compare
This makes it easier to use the plugin with pipeline.
Instead of
matchKeythe steps can also usematchJql,matchChangesandmatchChangesP4.Related issue
#101
Changes
Provide pipeline names for steps and selectors.
Tests
docs/directory