Skip to content

fix: styling of select boxes for issue and version parameter#761

Merged
rantoniuk merged 3 commits intojenkinsci:masterfrom
ugrave:bugfix/fix-760
Dec 9, 2025
Merged

fix: styling of select boxes for issue and version parameter#761
rantoniuk merged 3 commits intojenkinsci:masterfrom
ugrave:bugfix/fix-760

Conversation

@ugrave
Copy link
Contributor

@ugrave ugrave commented Nov 27, 2025

Related issue

#760

Changes

Before:
before

After:
after

Tests

  • I have updated/added relevant documentation in the docs/ directory
  • I have verified that the Code Coverage is not lower than before / that all the changes are covered as needed
  • I have tested my changes with a Jira Cloud / Jira Server

@ugrave ugrave requested a review from a team as a code owner November 27, 2025 13:02
@ugrave ugrave changed the title Fix styling of select boxes for issue and version parameter fix: styling of select boxes for issue and version parameter Nov 27, 2025
github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 28, 2025
View reviewed changes
@ugrave ugrave force-pushed the bugfix/fix-760 branch 6 times, most recently from 5b439d4 to 3cfb0c9 Compare November 28, 2025 12:58
rantoniuk
rantoniuk requested changes Dec 1, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 1, 2025
View reviewed changes
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2025
View reviewed changes
src/test/java/hudson/plugins/jira/listissuesparameter/JiraIssueParameterDefinitionTest.java
ListBoxModel.Option option = result.get(0);
assertEquals("", option.value);
assertEquals(Messages.JiraIssueParameterDefinition_NoIssueMatchedSearch(), option.name);
verify(job).hasPermission(Item.BUILD);

Check warning

Code scanning / Jenkins Security Scan

Result of hasPermission call is ignored Warning test

The result of the call is ignored
src/test/java/hudson/plugins/jira/versionparameter/JiraVersionParameterDefinitionTest.java
ListBoxModel.Option option = result.get(0);
assertEquals("", option.value);
assertEquals(Messages.JiraVersionParameterDefinition_NoIssueMatchedSearch(), option.name);
verify(job).hasPermission(Item.BUILD);

Check warning

Code scanning / Jenkins Security Scan

Result of hasPermission call is ignored Warning test

The result of the call is ignored
@ugrave ugrave force-pushed the bugfix/fix-760 branch 2 times, most recently from 963b752 to bec1d67 Compare December 4, 2025 08:47
rantoniuk
rantoniuk reviewed Dec 4, 2025
View reviewed changes
Copy link
Member

@rantoniuk rantoniuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost ready!

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2025
View reviewed changes
src/test/java/hudson/plugins/jira/listissuesparameter/JiraIssueParameterDefinitionTest.java
ListBoxModel.Option option = result.get(0);
assertEquals("", option.value);
assertEquals(Messages.JiraIssueParameterDefinition_NoIssueMatchedSearch(), option.name);
verify(job).hasPermission(Item.BUILD);

Check warning

Code scanning / Jenkins Security Scan

Result of hasPermission call is ignored Warning test

The result of the call is ignored
src/test/java/hudson/plugins/jira/versionparameter/JiraVersionParameterDefinitionTest.java
ListBoxModel.Option option = result.get(0);
assertEquals("", option.value);
assertEquals(Messages.JiraVersionParameterDefinition_NoIssueMatchedSearch(), option.name);
verify(job).hasPermission(Item.BUILD);

Check warning

Code scanning / Jenkins Security Scan

Result of hasPermission call is ignored Warning test

The result of the call is ignored
rantoniuk
rantoniuk reviewed Dec 5, 2025
View reviewed changes
@rantoniuk
Copy link
Member

rantoniuk commented Dec 5, 2025

Please don't use force-pushing when adressing review comments because it makes it harder to review changes - the PR will be squashed anyway during merge.

@rantoniuk rantoniuk merged commit 10c9a6e into jenkinsci:master Dec 9, 2025
16 checks passed
@ugrave ugrave deleted the bugfix/fix-760 branch December 11, 2025 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rantoniuk rantoniuk rantoniuk requested changes

Assignees

No one assigned

Labels

feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ugrave @rantoniuk