[JENKINS-41177] Reduce noise when showing diff between configs #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There is no reason to duplicate the same steps to build list of diff lines for two config files. Instead, extract this logic into a separate method, pull it up to JobConfigHistoryBaseAction and let three children of JobConfigHistoryBaseAction reuse it. Signed-off-by: Mykola Nikishov <[email protected]>
Instead of relying on core to store XML configs in a deterministic way, Job Config History plugin adds an intermediate step before converting XML to string representation and computing textual diff: - sort XML elements and attributes alphabetically - remove empty XML elements and attributes This way list of changed lines is deterministic and contains minimal semantically useless changes. Signed-off-by: Mykola Nikishov <[email protected]>
Member
|
Thanks, @manandbytes ! |
Contributor
Author
You're welcome! |
Member
|
I'm looking forward to make a new release, soon. I just wait on #79. |
Member
|
@manandbytes New version released. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.