refactor: remove usage of NumberUtils#80
Merged
basil merged 3 commits intojenkinsci:masterfrom Jul 31, 2025
Merged
Conversation
Signed-off-by: Bob Du <i@bobdu.cc>
Signed-off-by: Bob Du <i@bobdu.cc>
NumberUtils
basil
approved these changes
Jul 31, 2025
Member
basil
left a comment
There was a problem hiding this comment.
Thanks Bob. Ideally for changes that are slightly more risky like this, we'd do testing with the core test suite, PCT, and ATH. I'll run these tests after merging this and update the links here so you can see how I did it. If you (or someone else) ever does prepare a core PR to remove Commons Lang 2, we'd definitely want those tests run for that.
Member
|
@BobDu I tested this PR (and all your other changes) here:
Those 3 PRs show how to run a comprehensive set of tests on a given change. I found only one small test-only regression in the Pipeline: Nodes and Processes plugin. I opened a PR to fix that here: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #41 (comment)
I created a test case and run the unit test on the pre-refactored and post-refactored versions, and both passed successfully.
Testing done
Submitter checklist