feat: allow to ignore volumes during reconciliation

[BenjaminHerbert]

Changes

This is work in progress.

Allows to ignore volumes.

Closes #1078

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

• Includes tests (if functionality changed/added)
• Includes docs (if user facing)
• Commit messages follow commit message best practices

See the contribution guide for more details.

[BenjaminHerbert]

If this is going in the right direction, I can complete the other entries discussed in #1078.

• IgnoredAnnotations
• IgnoredEnvVars
• IgnoredLabels

[BenjaminHerbert]

Not sure if there is a notification about a draft. Could you give me a feedback, if this goes into the right direction, @brokenpip3?

[brokenpip3]

Not sure if there is a notification about a draft. Could you give me a feedback, if this goes into the right direction, @brokenpip3?

yes sorry, will take a look asap!

[brokenpip3]

Sorry if took me a while, the PR looks good as start, we can continue like this for the others :)
However f possible let's not add directly IgnoredVolumes or IgnoredXXXX but a more comprehensive struct like:

type JenkinsSpec struct {
	[...]
	Lifecycle JenkinsLifecycle `json:"lifecycle,omitempty"`
}

type JenkinsLifecycle struct {
	Ignore JenkinsLifecycleIgnore `json:"ignore,omitempty"`
}

type JenkinsLifecycleIgnore struct {
	IgnoredVolumes []string `json:"volumes,omitempty"`
	IgnoredEnvs []string `json:"envs,omitempty"`
	IgnoredAnnotations []string `annotations:"envs,omitempty"`
	IgnoredLabels []string `json:"labels,omitempty"`
}

so we can express it like that:

kind: Jenkins
metadata:
  name: example
spec:
  lifecycle:
    ignore:
      volumes:
        - /var/lib/jenkins/cache
        - /var/lib/jenkins/tmp
      envs:
       - FOOBAR

you can continue to adjust the unit tests and I can instead add the e2e tests for cover your changes, don't worry about that part, it's something I can complete.

thanks again for your contribution!

[BenjaminHerbert]

I have adapted your changes and implemented ignoring of annotations and volumes.

[BenjaminHerbert]

Could you trigger the e2e tests again, @brokenpip3? I think this 1e18160 should fix the failing test?

[brokenpip3]

I see that we added the ignore envs and labels but they are not implemented, do you want to implement them? otherwise you can comment the struct entries for the moment and we can only review/merge the annotations and volumes part