feat(backup): improve temporary file handling and cleanup #1154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Hi @brokenpip3 We are experiencing an issue where during abnormal termination of backups, old garbage tmp.XXXXXXXXX directories continue to live in our pvc wasting space At some point, this leads to catastrophic failure where jenkins fails to restore from a backup on startup and so the whole instance remains broken until someone manually cleans up stale directories |
dir01
commented
Dec 29, 2025
| _log "INFO" "[backup] running backup ${BACKUP_NUMBER}" | ||
| touch "${TRAP_FILE}" | ||
|
|
||
| # since at this point we are sure that no other backup process is running, we can clean up stale tmp dirs |
Author
There was a problem hiding this comment.
Is it safe to assume that? I mean, trap file protects us against concurrent runs with the same number, but is it possible that another backup with a lower or higher number runs concurrently?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.