-
Notifications
You must be signed in to change notification settings - Fork 1.3k
ContainerListenDecorator
#2837
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
jglick
wants to merge
42
commits into
jenkinsci:master
Choose a base branch
from
jglick:ContainerStepExecution
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
ContainerListenDecorator
#2837
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
2170791
Sketch of `ContainerListenDecorator`
jglick a257bd1
SpotBugs
jglick 7130253
NPE in `PodTemplateBuilderTest`
jglick d4706f2
At least basic handling of env vars
jglick f85935f
Properly quote `LOC`
jglick 79de706
`test` rather than `-f` maybe clearer
jglick 455e199
Use container env for clarity
jglick b58c5c9
Preparing a bootstrap system
jglick ab2b091
Filter environment variables in ContainerListenDecorator
jglick 4060416
Stylistic cleanups
jglick 95b67da
Easier to read multiline script
jglick 368dc88
Noting constraints on shell script
jglick d6d37b0
stdio (and exit code) working
jglick e8f98d3
Clean up the proc dir when we are done with it
jglick 9370a27
Suppressing irrelevant test
jglick 05f48d7
`KubernetesDeclarativeAgentTest.declarativeFromYamlWithNullEnv` was g…
jglick e178652
`RestartPipelineTest.terminatedPodAfterRestart` passed though decorat…
jglick 27244b7
Containers may use a different mount path for the workspace, or have …
jglick ea5a7c0
Quieter bootstrap script
jglick 0455475
Always `undecorate` the launcher, in case `container` step is used in…
jglick 741b23e
Silly result of IDE convert anon inner to nested
jglick e444656
Simpler way of finding `Pod`
jglick f8613b0
Noting to Claude how to run tests
jglick 4b496c7
`ContainerExecDecoratorPipelineTest.docker` asserts `maskedPrintComma…
jglick 07ad3c6
`KubernetesDeclarativeAgentTest.declarativeWithNestedExplicitInherita…
jglick 6a6bbc0
Merge branch 'master' of https://github.com/jenkinsci/kubernetes-plug…
jglick 93b304a
`KubernetesPipelineTest#runWithEnvVariablesInContext` covers `BASH_CO…
jglick 41e46f7
`KubernetesPipelineTest#runInPod` as of #244 was getting confused by …
jglick 9d17d01
`KubernetesPipelineTest#interruptedPod` fixed by implementing `Launch…
jglick 25278c5
Pick up https://github.com/jenkinsci/jenkins-test-harness/pull/1175
jglick ee5a90b
Straightforward enough to handle `ContainerStep.shell` correctly, but…
jglick 964ba3f
https://github.com/jenkinsci/durable-task-plugin/pull/561 released
jglick b2575f5
Switch from system property to cloud flag
jglick 467ee14
Gratuitous modifiers
jglick 6af12ad
Merge branch 'ltsc2022' into ContainerStepExecution
jglick 517182b
Politely falling back to original impl on Windows
jglick 4b467c3
Noting new mode in README
jglick f238341
Merge branch 'master' into ContainerStepExecution
jglick 6d61b6a
Merge branch 'ltsc2022' into ContainerStepExecution
jglick d8cf4d7
Merge branch 'master' into ContainerStepExecution
jglick 3ca3f27
Revert "Straightforward enough to handle `ContainerStep.shell` correc…
jglick 2a9b72c
Disable by default; introduce dedicated test class; tone down logging
jglick File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| All tests in this plugin which touch an actual Kubernetes cluster (mainly those extending @src/test/java/org/csanchez/jenkins/plugins/kubernetes/pipeline/AbstractKubernetesPipelineTest.java) require you to pass `-Pktunnel` to Maven. | ||
| Also use `-DforkCount=1` when running multiple cluster-based test classes at once to disable concurrency, since the tests use fixed port numbers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was misformatted