Conversation
Bumps [org.jenkins-ci:jenkins](https://github.com/jenkinsci/pom) from 1.142 to 2.1328.vfd10e2339a_19. - [Release notes](https://github.com/jenkinsci/pom/releases) - [Changelog](https://github.com/jenkinsci/pom/blob/master/CHANGELOG-old.md) - [Commits](https://github.com/jenkinsci/pom/commits) --- updated-dependencies: - dependency-name: org.jenkins-ci:jenkins dependency-version: 2.1328.vfd10e2339a_19 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
jtnord
requested changes
Jan 16, 2026
Member
There was a problem hiding this comment.
this library has no business requiring java21.
It is used outside of Jenkins (maven plugins) and has its own lifecycle. needs to be restricted to java17 (but in reality could probably even be 11)
jenkinsci/jenkins#26018
As noted by James Nord in #149 (review) > this library has no business requiring java21. > It is used outside of Jenkins (maven plugins) and has its own > lifecycle. needs to be restricted to java17 (but in reality could probably > even be 11)
Contributor
Thanks! I've pushed two changes to set the compiler release to Java 17 and to test with Java 17. I confirmed that the library compiles and passes tests with Java 17. @jtnord if that's sufficient, could you approve and merge this pull request? |
jtnord
approved these changes
Jan 16, 2026
dependabot
bot
deleted the
dependabot/maven/org.jenkins-ci-jenkins-2.1328.vfd10e2339a_19
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps org.jenkins-ci:jenkins from 1.142 to 2.1328.vfd10e2339a_19.
Release notes
Sourced from org.jenkins-ci:jenkins's releases.
... (truncated)
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)