Skip to content

Require Jenkins 2.479.3 and Jakarta EE 9#73

Merged
mjeanson merged 2 commits into
jenkinsci:masterfrom
strangelookingnerd:migrate
Aug 26, 2025
Merged

Require Jenkins 2.479.3 and Jakarta EE 9#73
mjeanson merged 2 commits into
jenkinsci:masterfrom
strangelookingnerd:migrate

Conversation

@strangelookingnerd

@strangelookingnerd strangelookingnerd commented Jul 1, 2025

Copy link
Copy Markdown
Contributor

Require Jenkins 2.479.3 and Jakarta EE 9

Jenkins 2.479.3 provides Jakarta EE 9, Eclipse Jetty 12, Spring Security 6, and Java 17.

  • Update plugin pom and baseline
  • Remove deprecations
  • Use Java 17 language features
  • Minor cleanup

Testing done

mvn clean verify

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

github-advanced-security[bot]
github-advanced-security AI found potential problems Jul 1, 2025
View reviewed changes
Comment thread src/main/java/hudson/plugins/libvirt/PluginImpl.java
}

public void doComputerNameValues(StaplerRequest req, StaplerResponse rsp,
public void doComputerNameValues(StaplerRequest2 req, StaplerResponse2 rsp,

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If PluginImpl#doComputerNameValues connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

@strangelookingnerd strangelookingnerd Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to these changes, should however be fixed in a separate PR

Comment thread src/main/java/hudson/plugins/libvirt/PluginImpl.java
}

public void doSnapshotNameValues(StaplerRequest req, StaplerResponse rsp,
public void doSnapshotNameValues(StaplerRequest2 req, StaplerResponse2 rsp,

Check warning

Code scanning / Jenkins Security Scan

Stapler: Missing POST/RequirePOST annotation Warning

Potential CSRF vulnerability: If PluginImpl#doSnapshotNameValues connects to user-specified URLs, modifies state, or is expensive to run, it should be annotated with @POST or @RequirePOST

@strangelookingnerd strangelookingnerd Jul 1, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated to these changes, should however be fixed in a separate PR

@mjeanson mjeanson merged commit 6fc9932 into jenkinsci:master Aug 26, 2025
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@strangelookingnerd @github-advanced-security @mjeanson