Open
Conversation
LEDfan
commented
Apr 28, 2021
| verify(mockBuild).getId(); | ||
| verify(mockBuild, times(2)).getResult(); | ||
| verify(mockBuild, times(2)).getParent(); | ||
| verify(mockBuild, atLeast(2)).getParent(); |
Author
There was a problem hiding this comment.
I used atLeast instead of a fixed value here, because the amount of calls varies depending on the value returned by mockBuild.getCauses, therefore it depends on the exact contents of the test
Based on the similar implementation of the datadog plugin [1]. - the userId is `scm` when the build was triggered by SCM - the userId is `timer` when the build was triggered by a timer - when the build was triggered by an upstream build, the userId of that build is used - in all other cases the userId is `anonymous`. [1] https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/java/org/datadog/jenkins/plugins/datadog/model/BuildData.java#L624
Author
|
Hi @jakub-bochenski , could you be so kind to have a look at this PR? It would be very useful for us to have this included. Thanks in advance, but no worries if you do not have the time for it. |
|
Very interested in this as well. Hope to see this implemented/merged soon. |
jakub-bochenski
force-pushed
the
master
branch
from
235a64b to
dbe90c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi
For one of my projects, I gratefully use this plugin, however, it would be nice if the data in ElasticSearch included the username that triggered the build. I saw that there is a similar plugin that support datadog, that actually sends the userId. I copied their implementation into this plugin (and adapted the code a bit). In my test-cases this works very well. I added a test-case for all possible ways in which the userId can be determined.
I hope you can accept this PR, any feedback is welcome!
Implementation notes;
scmwhen the build was triggered by SCMtimerwhen the build was triggered by a timerbuild is used
anonymous.[1] https://github.com/jenkinsci/datadog-plugin/blob/master/src/main/java/org/datadog/jenkins/plugins/datadog/model/BuildData.java#L624