Skip to content

Format file with Prettier#165

Merged
daniel-beck merged 2 commits intojenkinsci:masterfrom
basil:prettier
Jan 27, 2025
Merged

Format file with Prettier#165
daniel-beck merged 2 commits intojenkinsci:masterfrom
basil:prettier

Conversation

@basil
Copy link
Member

@basil basil commented Oct 22, 2024

Run npx prettier --print-width 999 -w jenkinsci/matrix-auth-plugin/src/main/resources/hudson/security/table.js on this file to make it easier to read.

If we want to drop the --print-width option (which results in even more invasive changes) I can do that as well.

If this PR isn't desired, that is fine as well. We can simply close it and leave the status quo; I don't feel strongly about this.

Testing done

None, but I trust Prettier to not introduce new bugs.

@basil basil requested a review from a team as a code owner October 22, 2024 14:58
@daniel-beck
Copy link
Member

Thanks and sorry for the delayed response. I kept wondering whether this is going to be useful long term, and for me it comes down to whether this is in scope for being enforced by Spotless or similar during the build. I guess not since you're only changing this file?

@basil
Copy link
Member Author

basil commented Jan 13, 2025

Yes, I am only changing this file.

@daniel-beck daniel-beck merged commit 9cff605 into jenkinsci:master Jan 27, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants