[JENKINS-75329] replace findAncestor with plain javascript#168
Merged
daniel-beck merged 1 commit intojenkinsci:masterfrom Mar 15, 2025
Merged
[JENKINS-75329] replace findAncestor with plain javascript#168daniel-beck merged 1 commit intojenkinsci:masterfrom
daniel-beck merged 1 commit intojenkinsci:masterfrom
Conversation
findAncestor is marked deprecated in Jenkins core and logs a warning. As this method is used quite a lot this leads to many warnings being logged which seems to slow down the the page significantly when many users/groups are present
daniel-beck
approved these changes
Mar 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JENKINS-75329
findAncestoris marked deprecated in Jenkins core and logs a warning. As this method is used quite a lot this leads to many warnings being logged which seems to slow down the page significantly when many users/groups are presentOn a page with 42 users/groups I get over 8200 calls to
findAncestorTesting done
Interactive testing showed no more warnings in the browser console
Submitter checklist