Makes AuthorizationContainer extend Describable#169
Merged
daniel-beck merged 1 commit intojenkinsci:masterfrom Mar 31, 2025
Merged
Conversation
This is for compatibility work with a core change i'm preparing...
14 tasks
AuthorizationContainer extend Describable
6 tasks
Member
Author
|
ping @daniel-beck (btw, @jenkinsci/matrix-auth-plugin-developers is empty) |
Member
|
Is this a prerequisite for the core change? What makes |
Member
Author
|
This is required to apply the changes to |
Member
|
I see, that makes sense and would indicate it's exclusive to my class hierarchy here. Unsure whether I will have time to address this PR this week, but should be in a release next week. |
Member
|
Why not just adjust those two tests to use |
daniel-beck
approved these changes
Mar 31, 2025
Member
daniel-beck
left a comment
There was a problem hiding this comment.
This seems so much cleaner than before, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for compatibility with core tests updated by jenkinsci/jenkins#10426
Testing done
Submitter checklist