Skip to content

Fix form validation in MBPL snippet generator #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
daniel-beck merged 1 commit into from
Aug 7, 2025
Merged

Fix form validation in MBPL snippet generator #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainerDescriptor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
import static org.jenkinsci.plugins.matrixauth.ValidationUtil.formatNonExistentUserGroupValidationResponse;
import static org.jenkinsci.plugins.matrixauth.ValidationUtil.formatUserGroupValidationResponse;

import edu.umd.cs.findbugs.annotations.CheckForNull;
import edu.umd.cs.findbugs.annotations.NonNull;
import hudson.Functions;
import hudson.security.AccessControlled;
Expand Down Expand Up @@ -139,7 +140,7 @@
// Not used directly by Stapler due to the trailing _ (this prevented method confusion around 1.415).
@Restricted(NoExternalUse.class)
default FormValidation doCheckName_(
@NonNull String value, @NonNull AccessControlled subject, @NonNull Permission permission) {
@NonNull String value, @CheckForNull AccessControlled subject, @NonNull Permission permission) {

final String unbracketedValue = value.substring(1, value.length() - 1); // remove leading [ and trailing ]

Expand All @@ -158,8 +159,8 @@

String escapedSid = Functions.escape(sid);

if (!subject.hasPermission(permission)) {
// Lacking permissions, so respond based on input only
if (subject == null || !subject.hasPermission(permission)) {

Check warning on line 162 in src/main/java/org/jenkinsci/plugins/matrixauth/AuthorizationContainerDescriptor.java

View check run for this annotation

ci.jenkins.io / Code Coverage

Partially covered line 

Line 162 is only partially covered, one branch is missing
// Lacking permissions or having a null subject, so respond based on input only
if (type == AuthorizationType.USER) {
return FormValidation.respond(
FormValidation.Kind.OK,
Expand Down
Loading