Skip to content

Support "Microsoft Entra ID"-plugin by displaying readable group names.#171

Closed
cvberg wants to merge 2 commits intojenkinsci:masterfrom
cvberg:fix-azure-group-display
Closed

Support "Microsoft Entra ID"-plugin by displaying readable group names.#171
cvberg wants to merge 2 commits intojenkinsci:masterfrom
cvberg:fix-azure-group-display

Conversation

@cvberg
Copy link

@cvberg cvberg commented Jun 14, 2025

When using this plugin in combination with the "Microsoft Entra ID" plugin, users specified using an OID
will be shown with a readable name. However, groups do not get the same treatment and will always show an OID.
This PR will solve that issue.
It's a literal copy of a change made to the "role-strategy-plugin": https://github.com/jenkinsci/role-strategy-plugin/pull/355/files
Jenkins issue: https://issues.jenkins.io/browse/JENKINS-75726

Using OIDs is unfortunately the only way to make the Microsoft Entra ID plugin and this plugin work together. This PR will make this limitation less problematic.

Testing done

  • I've tested this with the Entra ID plugin installed and the "Azure AD" authentication enabled. Before groups entered with a OID, will now show their Display Name instead.
  • I've also tested it with Active Directory authentication enabled. For AD, OIDs are not supported, so you must specify the group using the Display Name and that name will be shown unchanged.
  • I've repeated the previous test with the Entra ID plugin removed.

These tests have been done manually because I don't know how to add automated tests without having access to a real Entra ID system. I tested this at my workplace, where we do have this infrastructure.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@cvberg cvberg requested a review from a team as a code owner June 14, 2025 16:23
@cvberg cvberg marked this pull request as draft June 14, 2025 16:28
@cvberg cvberg force-pushed the fix-azure-group-display branch from 8340539 to 1310992 Compare June 14, 2025 16:30
@cvberg cvberg marked this pull request as ready for review June 14, 2025 16:31
@cvberg cvberg closed this Jun 14, 2025
@daniel-beck
Copy link
Member

FYI https://plugins.jenkins.io/azure-ad/ also has a Matrix Auth alternative implementation, in case the reason for closing this was something else. IIUC it supports autocompleting with UUIDs and similar features specifically useful to Entra ID.

@cvberg
Copy link
Author

cvberg commented Jun 15, 2025

Sorry, I made a mess of authorship in git. I'll prepare a new PR.
BTW: the people creating the Entra ID plugin.made the wrong choice when implementing permissions. They chose "matrix" instead of "project matrix". The latter supports inheritance, while the former doesn't.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants