Support "Microsoft Entra ID"-plugin by displaying readable group names.#171
Closed
cvberg wants to merge 2 commits intojenkinsci:masterfrom
Closed
Support "Microsoft Entra ID"-plugin by displaying readable group names.#171cvberg wants to merge 2 commits intojenkinsci:masterfrom
cvberg wants to merge 2 commits intojenkinsci:masterfrom
Conversation
8340539 to
1310992
Compare
Member
|
FYI https://plugins.jenkins.io/azure-ad/ also has a Matrix Auth alternative implementation, in case the reason for closing this was something else. IIUC it supports autocompleting with UUIDs and similar features specifically useful to Entra ID. |
Author
|
Sorry, I made a mess of authorship in git. I'll prepare a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using this plugin in combination with the "Microsoft Entra ID" plugin, users specified using an OID
will be shown with a readable name. However, groups do not get the same treatment and will always show an OID.
This PR will solve that issue.
It's a literal copy of a change made to the "role-strategy-plugin": https://github.com/jenkinsci/role-strategy-plugin/pull/355/files
Jenkins issue: https://issues.jenkins.io/browse/JENKINS-75726
Using OIDs is unfortunately the only way to make the Microsoft Entra ID plugin and this plugin work together. This PR will make this limitation less problematic.
Testing done
These tests have been done manually because I don't know how to add automated tests without having access to a real Entra ID system. I tested this at my workplace, where we do have this infrastructure.
Submitter checklist