Support "Microsoft Entra ID"-plugin by displaying readable group names.#172
Support "Microsoft Entra ID"-plugin by displaying readable group names.#172cvberg wants to merge 1 commit intojenkinsci:mainfrom
Conversation
|
Some comments on the usability of the Entra ID plugin regarding the usability of its own "azure-matrix" implementation. |
|
I doubt display names are unique, so this change looks like it would create ambiguity. Would it not make sense to apply the same check as in else block similarly, so that the UI allows access to OID via tooltip?
|
Doesn't need full Entra ID, "just" a security realm whose groups have different |
|
Makes sense to suppress the tooltip if it doesn't add new information. |
Is that the correct issue ID? |
|
My attempt at fixing this + test coverage is in #172. |
|
Closing in favor of #183. |
When using this plugin in combination with the "Microsoft Entra ID" plugin, users specified using an OID
will be shown with a readable name. However, groups do not get the same treatment and will always show an OID.
This PR will solve that issue.
It's a literal copy of a change made to the "role-strategy-plugin": https://github.com/jenkinsci/role-strategy-plugin/pull/355/files
Jenkins issue: https://issues.jenkins.io/browse/JENKINS-75726
Using OIDs is unfortunately the only way to make the Microsoft Entra ID plugin and this plugin work together. This PR will make this limitation less problematic.
Also, only the matrix-auth-plugin supports inheritance of permissions in folders and jobs, which is essential for me.
Testing done
These tests have been done manually because I don't know how to add automated tests without having access to a real Entra ID system. I tested this at my workplace, where we do have this infrastructure.
Submitter checklist