Wait before exiting testWidgets#174
Merged
daniel-beck merged 2 commits intojenkinsci:masterfrom Jul 16, 2025
Merged
Conversation
The testWidgets() test fails consistently on ci.jenkins.io since the transition from Azure to AWS. Since the tests are already using long sleep calls for various other purposes, let's sleep at the exit from the failing test so that there is time for Java to close files. Testing done Confirmed that `mvn clean verify` passes on my Linux computer. Rely on ci.jenkins.io to confirm the fix works on Windows.
The 3 second sleep was enough in 3 of 4 test runs. Let's see if a 5 second sleep improves the failure rate.
93 tasks
Member
|
Seems like something that should be done in JTH, no? Or are the conditions so unusual that this is not widespread? |
Contributor
Author
It is not widespread as far as I can tell. From the 100+ plugins that I checked as part of Monday's transition from Azure to AWS, I found less than five cases that needed this type of change. Two of those cases were specifically related to the Maven project type. I don't know the details of the conditions that cause the failure and was unwilling to spend the time to investigate those details because there were so few failing cases among so many tests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wait before exiting testWidgets
The
testWidgetstest has failed 2 out of 2 builds on the master branch since the transition of ci.jenkins.io from Azure to AWS. Other plugins have seen similar behavior and have reduced the failures significantly by waiting several seconds at the end of the test before exiting the test.Pull requests that have used that technique include:
A 3 second sleep was enough to pass 3 of 4 test runs in pull request:
Testing done
Confirmed that the tests pass locally. Confirmed that the tests pass on ci.jenkins.io 9 of 9 times. Ready for review
Submitter checklist