Skip to content

Use Hamcrest matchers where possible#177

Merged
daniel-beck merged 1 commit intojenkinsci:masterfrom
basil:hamcrest
Jul 24, 2025
Merged

Use Hamcrest matchers where possible#177
daniel-beck merged 1 commit intojenkinsci:masterfrom
basil:hamcrest

Conversation

@basil
Copy link
Member

@basil basil commented Jul 23, 2025

While testing an unrelated change recently, I tripped over these assertions with an unhelpful error message. This PR should improve the error message when these assertions fail.

Testing done

Deliberately tripped the assertions and saw better error messages after this PR.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests that demonstrate the feature works or the issue is fixed

@basil basil added the test label Jul 23, 2025
@basil basil requested a review from a team as a code owner July 23, 2025 22:57
Copy link
Member

@daniel-beck daniel-beck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@daniel-beck daniel-beck merged commit 50ec01b into jenkinsci:master Jul 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants