OidcProperty follow-ups; Fix application of clock skew to generated credentials#654
Merged
Merged
Conversation
Vlatombe
commented
Sep 10, 2025
| accessToken.getLifetime(), | ||
| CLOCK.millis(), | ||
| getAllowedTokenExpirationClockSkewSeconds()); | ||
| (long) client.getConfiguration().getMaxClockSkew()); |
jtnord
reviewed
Sep 10, 2025
Vlatombe
changed the title
OidcProperty follow-upsOidcProperty follow-ups; Fix application of clock skew to generated credentials
…s a default implementation that is needed.
jtnord
previously approved these changes
Sep 10, 2025
Member
Author
|
Still working on cleaning up removed methods... |
Vlatombe
commented
Sep 10, 2025
| assertTrue(crumb.process(request, response, chain)); | ||
| } | ||
|
|
||
| @Test |
Member
Author
There was a problem hiding this comment.
Moved from OicSecurityRealmTest
Vlatombe
commented
Sep 10, 2025
| assertEquals(rootUrl, realm.getValidRedirectUrl("http://localhost/jenkins/../bar/")); | ||
| } | ||
|
|
||
| @Test |
Member
Author
There was a problem hiding this comment.
Moved to EscapeHatchTest
Vlatombe
commented
Sep 10, 2025
| if (FIPS140.useCompliantAlgorithms() && isDisableSslVerification()) { | ||
| throw new IllegalStateException(Messages.OicSecurityRealm_DisableSslVerificationFipsMode()); | ||
| } | ||
| try { |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #654 +/- ##
============================================
- Coverage 74.74% 74.60% -0.15%
+ Complexity 326 315 -11
============================================
Files 33 33
Lines 1299 1280 -19
Branches 179 176 -3
============================================
- Hits 971 955 -16
Misses 241 241
+ Partials 87 84 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
jglick
reviewed
Sep 10, 2025
Comment on lines
-795
to
-797
| @DataBoundSetter | ||
| @Deprecated | ||
| public void setDisableTokenVerification(boolean disableTokenVerification) throws FormException { |
Member
There was a problem hiding this comment.
Does this break CasC even if you set the flag to tolerate deprecated properties? (see #655)
jtnord
approved these changes
Sep 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows up reviews from #644
The new clock skew value was not correctly applied to the generated
OicCredentialsTesting done
Submitter checklist