Redirect to login page after failing to refresh access token

[guillegalor]

This PR changes the default behaviour when the refresh of an access token fails. Previously, only 'error=invalid_grant' triggered a login redirect. All other cases sent an HTTP error, shown below:

This is a problem when the refresh token expires (or becomes invalid for some other reason) before the jenkin session does.

Testing done

Submitter checklist

• Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
• Ensure that the pull request title represents the desired changelog entry
• Please describe what you did
• Link to relevant issues in GitHub or Jira
• Link to relevant pull requests, esp. upstream and downstream changes
• Ensure you have provided tests that demonstrate the feature works or the issue is fixed

[guillegalor]

I don't know much Java so the only check I did was running the whole test suite and checking that everything passes, I'm happy to do any more testing if necessary.

Sry for the incovenience and thanks

[michael-doubez]

Did you try it ?

I'd prefer a robust way to identify expired token and redirect rather than hiding other potential errors.

And it the code looks like that, the redirect and return part can be moved to the end of the function.