Fix expiration check for well-known configuration#758
Open
Zwyx wants to merge 1 commit into
Open
Conversation
While investigating for issue jenkinsci#757, I found that the logic here is inverted. `wellKnownExpires.isBefore(now)` is true when the expiry has passed (cache stale). So the config is re-downloaded on every call until 1h after first load, then sticks with the cached copy forever.
Contributor
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While investigating for issue #757, I found that the logic here is inverted.
wellKnownExpires.isBefore(now)is true when the expiry has passed (cache stale). So the config is re-downloaded on every call until 1h after first load, then sticks with the cached copy forever.Testing done
Not covered.
Submitter checklist
Link to relevant issues in GitHub or JiraLink to relevant pull requests, esp. upstream and downstream changesEnsure you have provided tests that demonstrate the feature works or the issue is fixed