[FIXED JENKINS-19557] - Improved MacroStringHelper in order to avoid sub...#35
Merged
rpetti merged 1 commit intojenkinsci:masterfrom Sep 13, 2013
Merged
Conversation
…substitution errors and improve performance. Resolves https://issues.jenkins-ci.org/browse/JENKINS-19557 Signed-off-by: Oleg Nenashev <nenashev@synopsys.com>
|
Jenkins » perforce-plugin #108 FAILURE |
Member
Author
|
BTW, buildEnvVars stills recursive in case of non-existent variables. It allows to collect all available versions for substitution, but may cause side effects in other plugins. |
Member
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
Member
Author
|
In addition, getDepot() should support substitution of node and global variables. Initial and updated implementations don't support it |
rpetti
added a commit
that referenced
this pull request
Sep 13, 2013
[FIXED JENKINS-19557] - Improved MacroStringHelper in order to avoid sub...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix allows to avoid substitution errors in logs during buildEnv() and improves performance of the job.
Resolves https://issues.jenkins-ci.org/browse/JENKINS-19557
Signed-off-by: Oleg Nenashev nenashev@synopsys.com