Double the amount of fetched logs with every click on fetch more #1034
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking on
There’s more to see - xMiBand fetching 150KiB more than last time is quite inefficient, both in terms of bandwidth usage and in human time spent waiting to click again and again.This PR is proposing to double the amount of log bytes fetched per click.
E.g. for a 2MiB file and only the tail fetched so far:
-> 15650 fetched (7.8x or 11.7MiB wasted) with 14 requests / 13 clicks
-> 4250 fetched (2.2x or 2.3MiB wasted) with 5 requests / 4 clicks
Testing done
Based on #704 for Linux:
(This is generating 2.5MiB of log bytes)
Submitter checklist