Skip to content

Make input proceed and abort buttons work#597

Merged
timja merged 1 commit intojenkinsci:mainfrom
timja:handle-input-step
Feb 24, 2025
Merged

Make input proceed and abort buttons work#597
timja merged 1 commit intojenkinsci:mainfrom
timja:handle-input-step

Conversation

@timja
Copy link
Member

@timja timja commented Feb 24, 2025

Added script and CSS from ConsoleNotes by outputting it from: h.generateConsoleAnnotationScriptAndStylesheet().

Re-registered JavaScript after adding to page with Behaviour.applySubtree

Note: There's a pre-existing issue in that if you click the proceed/ abort multiple times you'll get 404s then eventually a 500 in the server side logs, the issue is there in classic pipeline too

Fixes #568

Testing done

Used pipeline from #568 to approve and reject

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja added the bug Something isn't working label Feb 24, 2025
@timja timja requested a review from a team as a code owner February 24, 2025 09:58
@timja timja enabled auto-merge (squash) February 24, 2025 09:58
@timja timja merged commit 7c20134 into jenkinsci:main Feb 24, 2025
16 of 17 checks passed
@timja timja deleted the handle-input-step branch April 17, 2025 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proceed and Abort links are broken in pipeline-console

1 participant