Make input proceed and abort buttons work#597
Merged
timja merged 1 commit intojenkinsci:mainfrom Feb 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added script and CSS from ConsoleNotes by outputting it from:
h.generateConsoleAnnotationScriptAndStylesheet().Re-registered JavaScript after adding to page with
Behaviour.applySubtreeNote: There's a pre-existing issue in that if you click the proceed/ abort multiple times you'll get 404s then eventually a 500 in the server side logs, the issue is there in classic pipeline too
Fixes #568
Testing done
Used pipeline from #568 to approve and reject
Submitter checklist