-
-
Notifications
You must be signed in to change notification settings - Fork 73
Improve stage view #632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Improve stage view #632
Changes from 29 commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
1ce2fb5
Improve Job view
timja 220dac7
Merge branch 'main' into smaller-job-view
janfaracik 01e8b14
Update design
janfaracik 2ab1c47
Add timestamp
janfaracik 7a2e321
Update status-icon.tsx
janfaracik 8e10458
Update status-icon.tsx
janfaracik abbd699
Fix prettier
timja d5e64cb
Use ===
timja c6ebb88
Remove unused class
timja 18992c9
Merge branch 'main' into pr/632
janfaracik 6a21095
Fix status
janfaracik 363119f
Fix overflowing
janfaracik 2e13fda
Update single-run.scss
janfaracik e2d9310
Increase shown stages
timja df69467
Check if run is in progress before returning unknown
lewisbirks 27b6382
Naaaaative toooltipssssss
janfaracik 4dc0e59
Fix tooltip
janfaracik 46b9f14
Move to Tippy
janfaracik 25841ae
Update nodes.tsx
janfaracik 6d305ef
Fixes
janfaracik 6b856b0
Update tooltip.tsx
janfaracik 084aa2c
Update tooltip to include duration
janfaracik f746d95
Update nodes.scss
janfaracik afd9727
Merge branch 'main' into pr/632
janfaracik f115354
Fixes
janfaracik 4749b01
Update stage-details.tsx
janfaracik b6b6704
Merge branch 'main' into smaller-job-view
janfaracik c63d89b
Merge branch 'main' into pr/632
janfaracik 7928b3e
Update package-lock.json
janfaracik 2a5f46f
Add counter placeholder
janfaracik 2a00254
Merge branch 'main' into smaller-job-view
timja e6ace2f
Add rough UI for counter
janfaracik d7b1250
Merge branch 'smaller-job-view' of https://github.com/timja/pipeline-…
janfaracik 8d2a69d
Add provider for multi pipeline graph
lewisbirks 2aaf54a
Only load required resource bundles
lewisbirks d5e4ffc
Semi working
janfaracik 3a7afe7
Update PipelineGraphLayout.ts
janfaracik 9e698f0
Update PipelineGraphLayout.ts
janfaracik 483803c
Merge branch 'main' into smaller-job-view
janfaracik dccc20f
Merge branch 'main' into smaller-job-view
janfaracik 586372b
Adjust height
timja b0e414c
Prettier
timja 803d0fc
lift locale acquisition outside of provider
lewisbirks d6c6170
Swap test to playwright
timja 9b0e64d
Wait for build to complete
timja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,23 @@ | ||
| import React, { useEffect, useRef } from "react"; | ||
|
|
||
| declare global { | ||
| interface Window { | ||
| Behaviour: any; | ||
| } | ||
| } | ||
| import Tippy, { TippyProps } from "@tippyjs/react"; | ||
| import React from "react"; | ||
|
|
||
| /** | ||
| * Provides a bridge between React and the Jenkins' tooltip component | ||
| * A customized (and customizable) implementation of Tippy tooltips | ||
| */ | ||
| export default function Tooltip({ text, children }: TooltipProps) { | ||
| const ref = useRef<HTMLButtonElement>(null); | ||
|
|
||
| useEffect(() => { | ||
| if (!ref.current) { | ||
| return; | ||
| } | ||
|
|
||
| window.Behaviour?.applySubtree(ref.current.parentNode, true); | ||
| }, []); | ||
| export default function Tooltip(props: TippyProps) { | ||
| if (props.content === undefined) { | ||
| return props.children; | ||
| } | ||
|
|
||
| return ( | ||
| <span {...{ tooltip: text }} ref={ref}> | ||
| {children} | ||
| </span> | ||
| <Tippy | ||
| theme="tooltip" | ||
| animation="tooltip" | ||
| duration={250} | ||
| touch={false} | ||
| {...props} | ||
| > | ||
| {props.children} | ||
| </Tippy> | ||
| ); | ||
| } | ||
|
|
||
| interface TooltipProps { | ||
| text: string; | ||
| children: React.ReactNode; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,3 @@ | ||
| .app-page-body--one-column { | ||
| max-width: 95vw; | ||
| } | ||
|
|
||
| .pgw-user-specified-text { | ||
| overflow-wrap: break-word; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 changes: 5 additions & 0 deletions
5
...n/frontend/multi-pipeline-graph-view/multi-pipeline-graph/main/MultiPipelineGraphModel.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,9 @@ | ||
| import { Result } from "../../../pipeline-graph-view/pipeline-graph/main"; | ||
|
|
||
| export interface RunInfo { | ||
| id: string; | ||
| displayName: string; | ||
| timestamp: number; | ||
| duration: number; | ||
| result: Result; | ||
| } |
42 changes: 26 additions & 16 deletions
42
src/main/frontend/multi-pipeline-graph-view/multi-pipeline-graph/main/SingleRun.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
49 changes: 49 additions & 0 deletions
49
src/main/frontend/multi-pipeline-graph-view/multi-pipeline-graph/main/single-run.scss
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| .pgv-single-run { | ||
| display: grid; | ||
| grid-template-columns: 200px 1fr; | ||
| align-items: center; | ||
|
|
||
| // This is hacky - the pipeline graph is too tall and isn't centered | ||
| .PWGx-PipelineGraph-container { | ||
| height: 36px; | ||
|
|
||
| & > div { | ||
| margin-top: -36px; | ||
| } | ||
| } | ||
|
|
||
| &:last-of-type { | ||
| border-bottom: none; | ||
| } | ||
|
|
||
| .pgw-user-specified-text { | ||
| display: grid; | ||
| grid-template-columns: auto 1fr; | ||
| align-items: start; | ||
| gap: 0.125rem 0.625rem; | ||
| color: var(--text-color); | ||
| text-decoration: none; | ||
| transition: opacity var(--standard-transition); | ||
| word-break: normal; | ||
| overflow-wrap: anywhere; | ||
|
|
||
| span { | ||
| grid-area: 2 / 2; | ||
| color: var(--text-color-secondary); | ||
| font-size: var(--font-size-xs); | ||
| } | ||
|
|
||
| &:hover { | ||
| opacity: 0.75; | ||
| } | ||
|
|
||
| &:active { | ||
| opacity: 0.5; | ||
| } | ||
|
|
||
| svg { | ||
| width: 1.375rem; | ||
| height: 1.375rem; | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| .pgv-stages__group { | ||
| display: flex; | ||
| flex-direction: column; | ||
| gap: 0.5rem; | ||
| margin-top: 1rem; | ||
|
|
||
| .pgv-stages__heading { | ||
| display: flex; | ||
| font-size: var(--font-size-xs); | ||
| color: var(--text-color-secondary); | ||
| font-weight: var(--font-bold-weight); | ||
| margin-bottom: 0.25rem; | ||
| margin-top: 0; | ||
| } | ||
|
|
||
| &:first-of-type { | ||
| margin-top: 0; | ||
| } | ||
| } |
2 changes: 0 additions & 2 deletions
2
src/main/frontend/pipeline-console-view/pipeline-console/main/ConsoleLogCard.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want this based on the users locale?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#647