Skip to content

Introduce a State enum for the Pipeline/Stage representations#636

Merged
timja merged 4 commits intojenkinsci:mainfrom
lewisbirks:status-enum
Apr 22, 2025
Merged

Introduce a State enum for the Pipeline/Stage representations#636
timja merged 4 commits intojenkinsci:mainfrom
lewisbirks:status-enum

Conversation

@lewisbirks
Copy link
Contributor

There was a TODO action in the AbstractPipelineNode and other such classes that get converted into it to change the status param from a string to an enum with explicit known types without using the blue ocean representation. This PR resolves that.

Testing done

Unit tests should cover backwards compatibility.

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@lewisbirks lewisbirks requested a review from a team as a code owner April 22, 2025 10:29
@lewisbirks lewisbirks changed the title Introduce a StateEnum for the Pipeline/Stage representations Introduce a State enum for the Pipeline/Stage representations Apr 22, 2025
Copy link
Member

@timja timja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@timja timja added the internal label Apr 22, 2025
@timja timja merged commit aeb316a into jenkinsci:main Apr 22, 2025
17 checks passed
@lewisbirks lewisbirks deleted the status-enum branch April 22, 2025 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants