Skip to content

Fix order of names in steps#641

Merged
timja merged 5 commits intojenkinsci:mainfrom
janfaracik:fix-name-order
Apr 23, 2025
Merged

Fix order of names in steps#641
timja merged 5 commits intojenkinsci:mainfrom
janfaracik:fix-name-order

Conversation

@janfaracik
Copy link
Member

Small PR to correct the order of names in steps in the console view. Hides 'Print Message' and 'Shell Script' from being visible.

Before
image

After
image

Testing done

  • Works as expected

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@janfaracik janfaracik requested a review from a team as a code owner April 23, 2025 10:59
@timja timja added the enhancement New feature or request label Apr 23, 2025
@janfaracik janfaracik enabled auto-merge (squash) April 23, 2025 11:13
logger.debug("DisplayName After: '" + displayName + "'.");

// Ignore certain titles
if (title.equals("Shell Script") || title.equals("Print Message")) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need to check display name is set. I think there’s some times when the display name is thrown away with shell scripts

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrapped it in an if to confirm display name is set.

@janfaracik janfaracik disabled auto-merge April 23, 2025 11:14
@timja timja merged commit deebbc3 into jenkinsci:main Apr 23, 2025
17 checks passed
@janfaracik janfaracik deleted the fix-name-order branch April 23, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants