Skip to content

Update renovate node filter to current LTS#677

Merged
timja merged 1 commit intomainfrom
timja-patch-1
Apr 28, 2025
Merged

Update renovate node filter to current LTS#677
timja merged 1 commit intomainfrom
timja-patch-1

Conversation

@timja
Copy link
Member

@timja timja commented Apr 28, 2025

Testing done

Submitter checklist

  • Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
  • Ensure that the pull request title represents the desired changelog entry
  • Please describe what you did
  • Link to relevant issues in GitHub or Jira
  • Link to relevant pull requests, esp. upstream and downstream changes
  • Ensure you have provided tests - that demonstrates feature works or fixes the issue

@timja timja requested a review from a team as a code owner April 28, 2025 07:44
@timja timja added the chore a PR that adds to maintenance - used by Release Drafter label Apr 28, 2025
@timja timja enabled auto-merge (squash) April 28, 2025 07:45
@timja timja merged commit 493fad3 into main Apr 28, 2025
17 of 18 checks passed
@timja timja deleted the timja-patch-1 branch April 28, 2025 07:54
{
"matchPackageNames": ["node"],
"allowedVersions": "/20.[0-9]+.[0-9]+(.[0-9]+)?$/"
"allowedVersions": "/22.[0-9]+.[0-9]+(.[0-9]+)?$/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another way to handle this is to simply disable major updates for such dependency. We won't need to remember updating renovate.json in that case.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I guess that would be a similar outcome. Ideally what I want is for it to auto update to the next current LTS

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed that in #681 and #683. The fix is simple: when using node-version datasource (as done in #669), Renovate will automatically only push updates for LTS versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore a PR that adds to maintenance - used by Release Drafter

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants